]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
workspacesView: Do not skip entire overview transition
authorFlorian Müllner <fmuellner@gnome.org>
Sat, 11 Jul 2020 16:10:18 +0000 (18:10 +0200)
committerGeorges Basile Stavracas Neto <georges.stavracas@gmail.com>
Mon, 13 Jul 2020 17:24:42 +0000 (17:24 +0000)
Since commit af543daf1c3, we skip the overview transition when the
actual geometry hasn't been set yet. However with the new layout
manager, the only bit that still needs the separate geometry is
the transition of the view, the workspaces can do their transition
just fine.

https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/2969

js/ui/workspacesView.js

index a757badbbfba5d55bb1123eecf6e3af202ca6c1e..c74c6e9c7e4beb66d1d6452ca16491c5a44bbc8a 100644 (file)
@@ -551,20 +551,18 @@ class WorkspacesDisplay extends St.Widget {
         this.show();
         this._updateWorkspacesViews();
 
-        if (this._actualGeometry) {
-            for (let i = 0; i < this._workspacesViews.length; i++) {
-                let animationType;
-                if (fadeOnPrimary && i == this._primaryIndex)
-                    animationType = AnimationType.FADE;
-                else
-                    animationType = AnimationType.ZOOM;
-                this._workspacesViews[i].animateToOverview(animationType);
-            }
-
-            if (!fadeOnPrimary)
-                this._syncWorkspacesActualGeometry();
+        for (let i = 0; i < this._workspacesViews.length; i++) {
+            let animationType;
+            if (fadeOnPrimary && i == this._primaryIndex)
+                animationType = AnimationType.FADE;
+            else
+                animationType = AnimationType.ZOOM;
+            this._workspacesViews[i].animateToOverview(animationType);
         }
 
+        if (this._actualGeometry && !fadeOnPrimary)
+            this._syncWorkspacesActualGeometry();
+
         this._restackedNotifyId =
             Main.overview.connect('windows-restacked',
                                   this._onRestacked.bind(this));